Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wolfssl: failing to set a session id is not reason to error out #7358

Closed
wants to merge 1 commit into from
Closed

wolfssl: failing to set a session id is not reason to error out #7358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions lib/vtls/wolfssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,15 +494,11 @@ wolfssl_connect_step1(struct Curl_easy *data, struct connectdata *conn,
&ssl_sessionid, NULL, sockindex)) {
/* we got a session id, use it! */
if(!SSL_set_session(backend->handle, ssl_sessionid)) {
char error_buffer[WOLFSSL_MAX_ERROR_SZ];
Curl_ssl_sessionid_unlock(data);
failf(data, "SSL: SSL_set_session failed: %s",
ERR_error_string(SSL_get_error(backend->handle, 0),
error_buffer));
return CURLE_SSL_CONNECT_ERROR;
Curl_ssl_delsessionid(data, ssl_sessionid);
infof(data, "Can't use session ID, going on without\n");
}
/* Informational message */
infof(data, "SSL re-using session ID\n");
else
infof(data, "SSL re-using session ID\n");
}
Curl_ssl_sessionid_unlock(data);
}
Expand Down