Fix some problems with the HTTP3 documentation #7842
Conversation
ghost
changed the title
|
I would like us to mention/recommend the same version ngtcp2 itself documents, so if this is the right version to move to, it would be great if you can get the ngtcp2 people to confirm that by updating their recommendation first. |
ghost
mentioned this pull request
|
Since we encourage the use of an installation prefix for this instruction, I think it implies that the user can actually create files there. I think the addition of sudo on all the lines for make install is a complication that we can skip, especially since you add the note in the bottom about it anyway. OpenSSL 3.0.0 puts the stuff in |
Thank you for reminding me about that I will edit it when I have time. I have to go to university for courses. |
My point: the instruction as it reads right now might fail on Linux x86-64 machines, which are quite commonly used! |
This comment has been minimized.
This comment has been minimized.
1. If writing to a system path if the command is not prefixed with `sudo` it will cause a permission denied error 2. The patched OpenSSL branch has been updated to `openssl-3.0.0+quic` to match upstream OpenSSL version. 3. We should not disable GnuTLS docs. If you believe my changes are wrong, feel free to request changes. Updated some commands about `make install` Make the `sudo` optional because one does not need to prepend `make install` with `sudo` all the time. http2: make getsock not wait for write if there's no remote window While uploading, check for remote window availability in the getsock function so that we don't wait for a writable socket if no data can be sent. Reported-by: Steini2000 on github Fixes #7821 Closes #7839 runtests: split out ignored tests Report ignore tests separately from the actual fails. Don't exit non-zero if test servers couldn't get killed. Assisted-by: Jay Satiro Fixes #7818 Closes #7841 tests: disable test 2043 It uses revoked.badssl.com which now is expired and therefor this now permafails. We should not use external sites for tests, this test should be converted to use our own infra. Closes #7845 curl: correct grammar in generated libcurl code Closes #7802 Added a note about OpenSSL > 3.0.0 Fixed the wording about the lib64 folder
ghost
requested a review
from
|
Thanks! |
sudoit will cause a permission denied erroropenssl-3.0.0+quicto match upstream OpenSSL version.autoreconfcommand should beautoreconf -fiIf you believe my changes are wrong, feel free to request changes.