ngtcp2: Specify the missing required callback functions#7929
Closed
tatsuhiro-t wants to merge 1 commit intomasterfrom
Closed
ngtcp2: Specify the missing required callback functions#7929tatsuhiro-t wants to merge 1 commit intomasterfrom
tatsuhiro-t wants to merge 1 commit intomasterfrom
Conversation
Member
I don't really have any better suggestion. It seems highly unlikely to ever actually occur in a working situation. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing ngtcp2 required callback functions.
cb_rand is meant not to fail, because the weak pseudo random number is just fine.
Curl_rand is a strong random data generator and may fail. In this PR, I just fill 0 in case of failure.
You might not like it though.