Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2: Specify the missing required callback functions #7929

Closed
wants to merge 1 commit into from

Conversation

@tatsuhiro-t
Copy link
Contributor

@tatsuhiro-t tatsuhiro-t commented Oct 31, 2021

This PR adds the missing ngtcp2 required callback functions.

cb_rand is meant not to fail, because the weak pseudo random number is just fine.
Curl_rand is a strong random data generator and may fail. In this PR, I just fill 0 in case of failure.
You might not like it though.

@bagder
Copy link
Member

@bagder bagder commented Nov 1, 2021

Curl_rand is a strong random data generator and may fail. In this PR, I just fill 0 in case of failure. You might not like it though.

I don't really have any better suggestion. It seems highly unlikely to ever actually occur in a working situation.

Loading

@bagder
Copy link
Member

@bagder bagder commented Nov 1, 2021

Thanks!

Loading

@bagder bagder closed this in e05c086 Nov 1, 2021
@bagder bagder deleted the ngtcp2-missing-callbacks branch Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants