Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2: support latest QUIC TLS RFC9001 #7960

Closed
wants to merge 1 commit into from

Conversation

@a-denoyelle
Copy link
Contributor

@a-denoyelle a-denoyelle commented Nov 4, 2021

QUIC Transport Parameters Extension has been changed between draft-29
and latest RFC9001. Most notably, its identifier has been updated from
0xffa5 to 0x0039. The version is selected through the QUIC TLS library
via the legacy codepoint.

Disable the usage of legacy codepoint in curl to switch to latest
RFC9001. This is required to be able to keep up with latest QUIC
implementations.

QUIC Transport Parameters Extension has been changed between draft-29
and latest RFC9001. Most notably, its identifier has been updated from
0xffa5 to 0x0039. The version is selected through the QUIC TLS library
via the legacy codepoint.

Disable the usage of legacy codepoint in curl to switch to latest
RFC9001. This is required to be able to keep up with latest QUIC
implementations.
@bagder
Copy link
Member

@bagder bagder commented Nov 5, 2021

@tatsuhiro-t this should be just fine, right?

Loading

@tatsuhiro-t
Copy link
Contributor

@tatsuhiro-t tatsuhiro-t commented Nov 5, 2021

It is fine. I'd suggest that ALPN should also be updated to h3 if v1 transport_parameters codepoint is used.

Loading

@bagder
Copy link
Member

@bagder bagder commented Nov 5, 2021

The RFC for QUIC v1 is already published though, while the HTTP/3 one isn't so shouldn't we strictly remain on h3-[draft] until the spec actually ships?

Loading

@tatsuhiro-t
Copy link
Contributor

@tatsuhiro-t tatsuhiro-t commented Nov 5, 2021

Good point. I think just continuing to use h3-29 would be fine.

Loading

@bagder
Copy link
Member

@bagder bagder commented Nov 5, 2021

Thanks both of you!

Loading

@bagder bagder closed this in d1624b9 Nov 5, 2021
tatsuhiro-t added a commit that referenced this issue Nov 9, 2021
Since we switched to v1 quic_transport_parameters codepoint in #7960
with quictls, lets use QUIC v1 consistently.
@tatsuhiro-t tatsuhiro-t mentioned this pull request Nov 9, 2021
bagder added a commit that referenced this issue Nov 9, 2021
Since we switched to v1 quic_transport_parameters codepoint in #7960
with quictls, lets use QUIC v1 consistently.

Closes #7979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants