Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Curl_getconnectinfo work with connection cache from share handle #8524

Conversation

meierfra-ergon
Copy link
Contributor

@meierfra-ergon meierfra-ergon commented Feb 28, 2022

I experienced that curl_easy_getinfo() with CURLINFO_ACTIVESOCKET does not return a socket, if I use a easy_handle with a share_handle set (curl_easy_setopt() with CURLOPT_SHARE).
The reason is that in the curl function Curl_getconnectinfo() does not check if the connection cache from the share_handle was used.
I propose the following pull request to address this issue.

BTW: A long time ago [1], I also proposed a patch in the same function to not only retrieve the last used connection of an easy_handle but also the currently active connection. If the above PR is acceptable I could also create a PR with this extended behavior. We use this for years now ;-).

[1] https://curl.se/mail/lib-2015-08/0116.html

@meierfra-ergon meierfra-ergon force-pushed the Curl_getconnectinfo_with_share_handle branch from d3272ac to 9644020 Compare Feb 28, 2022
bagder
bagder approved these changes Feb 28, 2022
@bagder
Copy link
Member

@bagder bagder commented Mar 8, 2022

Thanks!

@Cmo1976

This comment was marked as off-topic.

@Cmo1976

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants