make Curl_getconnectinfo work with connection cache from share handle #8524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced that curl_easy_getinfo() with CURLINFO_ACTIVESOCKET does not return a socket, if I use a easy_handle with a share_handle set (curl_easy_setopt() with CURLOPT_SHARE).
The reason is that in the curl function Curl_getconnectinfo() does not check if the connection cache from the share_handle was used.
I propose the following pull request to address this issue.
BTW: A long time ago [1], I also proposed a patch in the same function to not only retrieve the last used connection of an easy_handle but also the currently active connection. If the above PR is acceptable I could also create a PR with this extended behavior. We use this for years now ;-).
[1] https://curl.se/mail/lib-2015-08/0116.html