Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects: Fix the third-party SSL library build paths for Visual Studio #8991

Conversation

captain-caveman2k
Copy link
Member

@captain-caveman2k captain-caveman2k commented Jun 11, 2022

The paths used by the build batch files were inconsistent with those in
the Visual Studio project files - which means the OpenSSL and wolfSSL
builds would fail trying to link.

The paths used by the build batch files were inconsistent with those in
the Visual Studio project files.
@captain-caveman2k
Copy link
Member Author

@captain-caveman2k captain-caveman2k commented Jun 11, 2022

Note: This is not intended to fix the inconsistency in the Visual Studio version arguments between build-openssl.bat, build-wolfssl.bat and generate.bat.

@captain-caveman2k captain-caveman2k added build Windows labels Jun 11, 2022
@captain-caveman2k captain-caveman2k self-assigned this Jun 11, 2022
@bagder bagder requested a review from jay Jun 11, 2022
jay
jay approved these changes Jun 13, 2022
Copy link
Member

@jay jay left a comment

Ref: #8447

Ah my fault. Ok. Is there any reason not to change the vc arguments for the build- batch files as well? I don't remember why I didn't do that.

@bagder bagder closed this in aea8ac1 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants