-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl_setup: include system.h instead of curl.h #9453
Closed
MarcelRaad
wants to merge
4
commits into
curl:master
from
MarcelRaad:stop_including_curl.h_before_setup
Closed
curl_setup: include system.h instead of curl.h #9453
MarcelRaad
wants to merge
4
commits into
curl:master
from
MarcelRaad:stop_including_curl.h_before_setup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The platform setup headers might set definitions required for the includes in curl.h. Ref: curl#9375 (comment) Closes
As done before commit 9506d01. Ref: curl#9375 (comment) Closes
mback2k
approved these changes
Sep 10, 2022
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Sep 12, 2022
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Sep 12, 2022
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Sep 12, 2022
As done before commit 9506d01. Ref: curl#9375 (comment) Closes curl#9453
jquepi
pushed a commit
to jquepi/curl.1.555
that referenced
this pull request
Oct 24, 2022
The platform setup headers might set definitions required for the includes in curl.h. Ref: curl/curl#9375 (comment) Closes curl/curl#9453
jquepi
pushed a commit
to jquepi/curl.1.555
that referenced
this pull request
Oct 24, 2022
jquepi
pushed a commit
to jquepi/curl.1.555
that referenced
this pull request
Oct 24, 2022
jquepi
pushed a commit
to jquepi/curl.1.555
that referenced
this pull request
Oct 24, 2022
As done before commit 9506d01. Ref: curl/curl#9375 (comment) Closes curl/curl#9453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and after the platform setup headers instead of before them.
This makes the definitions set in the platform setup headers apply to the platform includes in system.h.