Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winidn: drop WANT_IDN_PROTOTYPES #9793

Closed
wants to merge 1 commit into from

Commits on Oct 26, 2022

  1. winidn: drop WANT_IDN_PROTOTYPES

    `WANT_IDN_PROTOTYPES` was necessary to avoid using a header that came
    via an optional package. MS stopped distributing this package some
    years ago and the winidn definitions are part of standard headers (via
    `windows.h`) since Vista.
    
    Auto-detect Vista inside `lib/idn_win32.c` and enable the manual
    definitions if building for an older Windows.
    
    This allows to delete this manual knob from all build-systems.
    
    Also drop the `_SAL_VERSION` sub-case:
    
    The definitions are now only enabled with old systems. We assume that
    code analysis is not run on such systems, allowing us to delete the
    SAL-friendly flavour of these.
    vszakats committed Oct 26, 2022
    Copy the full SHA
    a76e055 View commit details
    Browse the repository at this point in the history