Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewind BEFORE request instead of AFTER previous #9958

Closed
wants to merge 2 commits into from
Closed

rewind BEFORE request instead of AFTER previous #9958

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Nov 22, 2022 •
edited

This makes a big difference for cases when the rewind is not actually necessary to perform (for example HTTP response code 301 converts to GET) and therefore the rewind can be avoided. In particular for situations when that rewind fails.

bagder added a commit that referenced this pull request Nov 22, 2022
@bagder
lib: rewind BEFORE request instead of AFTER previous
445999a 
This makes a big difference for cases when the second request is not
actually performed (for example HTTP response code 301 converts to GET)
and therefore the rewind can be avoided. In particular for situations
when that rewind *fails*.

Reported-by: Ali Utku Selen

Fixes #9735
Closes #9958
bagder added a commit that referenced this pull request Nov 22, 2022
@bagder
lib: rewind BEFORE request instead of AFTER previous
59c53a4 
This makes a big difference for cases when the second request is not
actually performed (for example HTTP response code 301 converts to GET)
and therefore the rewind can be avoided. In particular for situations
when that rewind *fails*.

Reported-by: Ali Utku Selen

Fixes #9735
Closes #9958
@bagder
lib: rewind BEFORE request instead of AFTER previous
77ee2d8 
This makes a big difference for cases when the second request is not
actually performed (for example HTTP response code 301 converts to GET)
and therefore the rewind can be avoided. In particular for situations
when that rewind *fails*.

Reported-by: Ali Utku Selen

Fixes #9735
Closes #9958
@bagder
test1662: verify formpost, 301 redirect, no rewind possible
2b3f62a 
Reproduces #9735 and verifies the subsequent fix. The original issue
uses a pipe that cannot be rewound, but this test case instead sets a
callback without rewind ability to get roughly the same properties but
being a much more portable test.
@bagder bagder closed this in 1b39731 Nov 25, 2022
@bagder bagder deleted the bagder/rewind branch November 25, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HTTP libcurl API
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder