Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewind BEFORE request instead of AFTER previous #9958

Closed
wants to merge 2 commits into from
Closed

rewind BEFORE request instead of AFTER previous #9958

wants to merge 2 commits into from

Commits on Nov 24, 2022

  1. lib: rewind BEFORE request instead of AFTER previous 

    This makes a big difference for cases when the second request is not
actually performed (for example HTTP response code 301 converts to GET)
and therefore the rewind can be avoided. In particular for situations
when that rewind *fails*.

Reported-by: Ali Utku Selen

Fixes #9735
Closes #9958
    @bagder
    bagder committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    77ee2d8 View commit details
    Browse the repository at this point in the history

  2. test1662: verify formpost, 301 redirect, no rewind possible 

    Reproduces #9735 and verifies the subsequent fix. The original issue
uses a pipe that cannot be rewound, but this test case instead sets a
callback without rewind ability to get roughly the same properties but
being a much more portable test.
    @bagder
    bagder committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    2b3f62a View commit details
    Browse the repository at this point in the history