Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doh: fix build for windows #2

Closed
wants to merge 1 commit into from
Closed

Conversation

jay
Copy link
Member

@jay jay commented May 1, 2018

  • (Windows) Define bool type for < VS2013 since those versions are
    missing stdbool.h.

  • (Windows) Use size_t format specifier %Iu instead of %zu, since the
    latter is not supported by older CRTs.

  • (Windows) Search and set the CA certificate bundle in the path.

Closes #xxxx


The Makefile output looks wrong so I didn't use it to build. It did this

make CFLAGS="-I/usr/local/include" LDFLAGS="-L/usr/local/lib -lcurl"
cc -I/usr/local/include   -c -o doh.o doh.c
cc -L/usr/local/lib -lcurl  doh.o   -o doh
doh.o:doh.c:(.text+0x101c): undefined reference to `__imp__curl_easy_init'

but I'm pretty sure that's out of order and should be a link command or ordered like cc -o doh doh.o -L/usr/local/lib -lcurl

- (Windows) Define bool type for < VS2013 since those versions are
  missing stdbool.h.

- (Windows) Use size_t format specifier %Iu instead of %zu, since the
  latter is not supported by older CRTs.

- (Windows) Search and set the CA certificate bundle in the path.

Closes #xxxx
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jay jay closed this in dab7451 May 2, 2018
@jay jay deleted the fix_build_for_windows branch May 2, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants