format null as \u0000 when calling with --json #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
jacobmealey
commented
Jun 1, 2023
emanuele6
reviewed
Jun 1, 2023
| @@ -263,8 +269,8 @@ struct option { | |||
| }; | |||
|
|
|||
| #define MAX_QPAIRS 1000 | |||
| char *qpairs[MAX_QPAIRS]; /* encoded */ | |||
| char *qpairsdec[MAX_QPAIRS]; /* decoded */ | |||
| struct string qpairs[MAX_QPAIRS]; /* encoded */ | |||
There was a problem hiding this comment.
what is the point of this change for encoded qpairs?
There was a problem hiding this comment.
It might make it easier to have both types using the same layout so switching between them gets easy.
emanuele6
reviewed
Jun 1, 2023
jacobmealey
force-pushed
the
null_with_json
branch
from
0917612
to
3c729bf
Compare
emanuele6
reviewed
Jul 9, 2023
bagder
pushed a commit
to curl/curl
that referenced
this pull request
Jul 9, 2023
Control characters without a special escape sequence e.g. %00 or %06 were being encoded as "u0006" instead of "\u0006". Ref: curl/trurl#214 (comment) Closes #11414
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Control characters without a special escape sequence e.g. %00 or %06 were being encoded as "u0006" instead of "\u0006". Ref: curl/trurl#214 (comment) Closes curl#11414
bagder
approved these changes
Aug 7, 2023
jacobmealey
force-pushed
the
null_with_json
branch
from
6b99b01
to
0dd09f8
Compare
|
Ahh there we go! it should be all set to merge now bagder, thanks! |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Control characters without a special escape sequence e.g. %00 or %06 were being encoded as "u0006" instead of "\u0006". Ref: curl/trurl#214 (comment) Closes curl#11414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--jsonencode a null byte as\u0000instead of.struct stringand makesqpairsandqpairsdecuse this instead of a char*