Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix SDK wrappers not compiling because in-app SDK installing in NSE #308

Merged
merged 1 commit into from
May 10, 2023

Conversation

levibostian
Copy link
Contributor

@levibostian levibostian commented May 4, 2023

@Shahroz16 only merge if you find that Ami RN iOS builds are fixed and no longer show the Gist compile-time errors.

@levibostian levibostian requested a review from Shahroz16 May 4, 2023 19:57
@github-actions
Copy link

github-actions bot commented May 4, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #308 (552fc27) into main (0946a76) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   56.07%   55.98%   -0.09%     
==========================================
  Files         105      105              
  Lines        1186     1186              
==========================================
- Hits          665      664       -1     
- Misses        521      522       +1     

see 1 file with indirect coverage changes

@levibostian levibostian self-assigned this May 9, 2023
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working.

@Shahroz16 Shahroz16 merged commit 8b96ba0 into main May 10, 2023
@Shahroz16 Shahroz16 deleted the levi/override-wrappers-nse branch May 10, 2023 09:22
@levibostian
Copy link
Contributor Author

@Shahroz16 Can you confirm that all SDK wrapper projects have been updated with the changes made in this PR?

@Shahroz16
Copy link
Contributor

@Shahroz16 Can you confirm that all SDK wrapper projects have been updated with the changes made in this PR?

@levibostian Its added in Ami RN and Ami Flutter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants