Moved quantity calculation to its own method calculateTotalQuantity()
#34
Conversation
Signed-off-by: Maarten Troonbeeckx <maarten@uni-t.be>
|
@sprankhub Failed checks don't seem to be related to the actual tests. Can you have a look? |
|
Sorry that it takes so long, but since this is a critical change and involves background processes (new release, update on Marketplace etc.), we need some more time. I definitely have it on my list and will check this PR as soon as possible. |
| const XML_PATH_IS_ENABLED = 'sales/customgento_configurabletierprices/is_enabled'; | ||
| const XML_PATH_DISABLED_FOR_CATEGORY = 'sales/customgento_configurabletierprices/disabled_for_category'; | ||
|
|
||
| // attribute code length must be less than 30 symbols! |
There was a problem hiding this comment.
Please keep this comment (as it is non-intuitive to use an abbreviated version of the extension name here).
| @@ -41,15 +39,15 @@ public function isProductInDisabledCategory(Mage_Catalog_Model_Product $product) | |||
|
|
|||
| public function isExtensionDisabledForProduct(Mage_Catalog_Model_Product $product) | |||
| { | |||
| // get the product attribute directly, because it may not be loaded | |||
| // Get the product attribute directly, because it may not be loaded | |||
There was a problem hiding this comment.
Please do not change such subtle things in a PR. It makes it harder to merge (and I prefer starting with lower case letters btw).
| /** | ||
| * @var CustomGento_ConfigurableTierPrices_Helper_Data | ||
| */ | ||
| protected $helper; |
| * | ||
| * @param Mage_Catalog_Model_Product $product | ||
| * | ||
| * @return float | ||
| */ | ||
| protected function _calcConfigProductTierPricing($product) | ||
| protected function calculateTierPrice($product) |
There was a problem hiding this comment.
Please rename to _calculateTierPrice.
| * | ||
| * @return int | ||
| */ | ||
| protected function calculateTotalQuantity($product) |
There was a problem hiding this comment.
Please rename to _calculateTotalQuantity.
| } | ||
|
|
||
| /** | ||
| * Retrieves all visible quote items from the session. | ||
| * | ||
| * @return array with instances of Mage_Sales_Model_Quote_Item | ||
| */ | ||
| protected function _getAllVisibleItems() | ||
| protected function getAllVisibleItems() |
There was a problem hiding this comment.
Please revert to _getAllVisibleItems.
|
@sprankhub Tnx for the feedback. Should be fixed now. Also reverted the inline comments in the Observer to start with a lower case. |
|
Thanks for the quick update! My colleague @norgeindian will further test and process this PR. |
|
@norgeindian Tnx! |
calculateTotalQuantity()@sprankhub I removed the underscores from the protected functions (PSR-2), hope this is ok for you? Personally, I hate them, but I know it's still common practice in M1... Feel free to add them again :)