Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding opacity parameter and trying to fix a bug with getTile function #252

Closed
wants to merge 11 commits into from

Conversation

xavijam
Copy link

@xavijam xavijam commented Sep 17, 2012

Further to #194 and #248.

@tmcw
Copy link

tmcw commented Sep 17, 2012

This implementation of opacity doesn't seem very sturdy. How could opacity be changed after adding the tiles? Can we change it on a parent element, not just tile-by-tile? Should this be in CSS rather than hardcoded, and are there polyfills to handle the ugly IE filters rather than hardcoding them?

@xavijam
Copy link
Author

xavijam commented Sep 17, 2012

I absolutely agree with you, it's not the best choice. I'd like to replicate Leaflet behavior setting the opacity in the parent dom element but didn't find enough time to improve it. Let me review it again.

@javisantana
Copy link

anyways, maybe we should use ImageMapType which supports opacity ?

https://developers.google.com/maps/documentation/javascript/reference?hl=es#ImageMapType

  • looks like I dont understand how pull requests work, why github added more commits to the pull requests?

@tmcw
Copy link

tmcw commented Sep 29, 2012

Yeah, ImageMapType looks good, maybe it does some magic for the png fixing as well.

Pull requests track branches, so if you make one on master, any commits you make to master will be automatically added to the request, so it's best to have like a this-feature branch just for a pull request and have only the relevant commits on it.

@tmcw
Copy link

tmcw commented Nov 6, 2012

Closing here - happy to merge (and might just be able to look at) a solution that uses ImageMapType instead of MapType. But this branch is currently a bit removed from the specific pull/feature at hand.

@tmcw tmcw closed this Nov 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants