Try harder to get a meaningful error message

cv-library · Jan 2, 2018 · 7988cc2 · 7988cc2
1 parent c8e0871
commit 7988cc2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -1,3 +1,6 @@
+0.101 2018-01-02
+    - Try harder to get a meaningful error message.
+
 0.100 2017-12-21
     - This is a breaking chance, we now support the latest WebDriver spec and
       test on the latest geckodriver, I suspect phantomjs no longer works, but

diff --git a/lib/WebDriver/Tiny.pm b/lib/WebDriver/Tiny.pm
@@ -302,8 +302,13 @@ sub _req {
 
     my $value = eval { JSON::PP::decode_json( $reply->{content} )->{value} };
 
-    Carp::croak ref $self, ' - ', $value ? $value->{message} : $reply->{content}
-        unless $reply->{success};
+    unless ( $reply->{success} ) {
+        my $error = $value
+            ? $value->{message} || $value->{error} || $reply->{content}
+            : $reply->{content};
+
+        Carp::croak ref $self, ' - ', $error;
+    }
 
     $value;
 }