Saving settings to local storage #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
reviewed
Mar 26, 2021
Comment on lines
+46
to
+64
| try { | ||
| const newSettings: any = {}; | ||
| const loadedSettings = JSON.parse(localStorage.getItem('clientSettings') as string); | ||
| for (const [sectionKey, section] of Object.entries(settings)) { | ||
| for (const [key, value] of Object.entries(section)) { | ||
| let settedValue = value; | ||
| if (sectionKey in loadedSettings && key in loadedSettings[sectionKey]) { | ||
| settedValue = loadedSettings[sectionKey][key]; | ||
| } | ||
| if (!(sectionKey in newSettings)) newSettings[sectionKey] = {}; | ||
| newSettings[sectionKey][key] = settedValue; | ||
| } | ||
| } | ||
| dispatch(setSettings(newSettings)); | ||
| } catch { | ||
| notification.error({ | ||
| message: 'Failed to load settings from local storage', | ||
| }); | ||
| } |
There was a problem hiding this comment.
Why not to do it in defaultState for settings reducer?
There was a problem hiding this comment.
First of all, code for saving and restoring settings is placed in the same place. Secondly, we will try to load settings after first render, so it's a very small time gain for the first render, i guess. And it will be easier to modify this solution for server side config loading, for example.
Comment on lines
+76
to
+83
| <Tooltip title='Will save settings from this page and appearance settings on standard workspace page in browser'> | ||
| <Button type='primary' onClick={onSaveSettings}> | ||
| Save | ||
| </Button> | ||
| </Tooltip> | ||
| <Button type='default' onClick={onClose}> | ||
| Close | ||
| </Button> |
There was a problem hiding this comment.
Need to update dock. Do we need button close? We have "X" and also click everywhere out of the modal closes the modal
There was a problem hiding this comment.
It's default behaviour for the modal element.
8 tasks
|
@TOsmanov, hi, can you adjust documentation according this new feature, please? |
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR provide saving user settings to local storage. Resolved #1209
How has this been tested?
Manually
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changescvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.