-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Remove a possibly duplicated encodeURI() (Issue #4428) #4947
Conversation
…non-ascii path (Issue cvat-ai#4428 Cannot connect file share,cannot recognize non-ascii path)
@rhee-elten , could you please add a line into CHANGELOG.md? |
@nmanovic , added a line in "Fix" section. |
/check |
❌ Some checks failed |
@rhee-elten , it looks like we have a problem with one of our tests? See https://github.com/opencv/cvat/actions/runs/3057664887/jobs/4933099377 for more details. Could you please check that after the fix dots in the name are handled properly? |
@rhee-elten , also need to fix a comment from the markdown linter: https://github.com/opencv/cvat/actions/runs/3052045457/jobs/4933043382 |
I hardly think that the PR is related with this test. It behaves quite unstable time to time. |
/check |
✔️ All checks completed successfully |
@rhee-elten Thank you for the contribution! |
FIX: Remove possibly duplicated encodeURI() to prevent double encode non-ascii path (Issue #4428 Cannot connect file share,cannot recognize non-ascii path)
Motivation and context
Resolved #4428
When you create a task and trying to select files from "Connected file share",
you get multiple "Could not load share data from the server" error popups
if you try to expand a directory named in non-ascii code.
How has this been tested?
Following documentation https://opencv.github.io/cvat/docs/administration/basics/installation/#share-path,
setup a share path for CVAT, which contains (sub)directory encoded in non ascii code.
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.