Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove a possibly duplicated encodeURI() (Issue #4428) #4947

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

rhee-elten
Copy link
Contributor

@rhee-elten rhee-elten commented Sep 14, 2022

FIX: Remove possibly duplicated encodeURI() to prevent double encode non-ascii path (Issue #4428 Cannot connect file share,cannot recognize non-ascii path)

Motivation and context

Resolved #4428

When you create a task and trying to select files from "Connected file share",
you get multiple "Could not load share data from the server" error popups
if you try to expand a directory named in non-ascii code.

How has this been tested?

Following documentation https://opencv.github.io/cvat/docs/administration/basics/installation/#share-path,
setup a share path for CVAT, which contains (sub)directory encoded in non ascii code.

  • Create a project and task, and then "Connected file share" tab under Select files section.
  • Click/expand directories until you encounter the non-ascii named directory.
  • Expand the non-ascii named directory and see that no error dialog pop-ups.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

…non-ascii path (Issue cvat-ai#4428 Cannot connect file share,cannot recognize non-ascii path)
@nmanovic
Copy link
Contributor

@rhee-elten , could you please add a line into CHANGELOG.md?

@rhee-elten
Copy link
Contributor Author

@nmanovic , added a line in "Fix" section.

@nmanovic
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

❌ Some checks failed
📄 See logs here

@nmanovic
Copy link
Contributor

@rhee-elten , it looks like we have a problem with one of our tests? See https://github.com/opencv/cvat/actions/runs/3057664887/jobs/4933099377 for more details. Could you please check that after the fix dots in the name are handled properly?

@nmanovic
Copy link
Contributor

@rhee-elten , also need to fix a comment from the markdown linter: https://github.com/opencv/cvat/actions/runs/3052045457/jobs/4933043382

@bsekachev
Copy link
Member

bsekachev commented Sep 15, 2022

@rhee-elten , it looks like we have a problem with one of our tests? See https://github.com/opencv/cvat/actions/runs/3057664887/jobs/4933099377 for more details. Could you please check that after the fix dots in the name are handled properly?

I hardly think that the PR is related with this test. It behaves quite unstable time to time.

CHANGELOG.md Outdated Show resolved Hide resolved
@bsekachev
Copy link
Member

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member

@rhee-elten Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot connect file share,cannot recognize non-ascii path
3 participants