-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard shortcut to delete frame (fixes #5369) #5370
Keyboard shortcut to delete frame (fixes #5369) #5370
Conversation
@scottykwok , thanks for the contribution! Let's see if all tests are passed. Could you please add a function test for the feature? Thus we will be sure that it works after our modifications. @klakhov , could you please review the PR? |
I am not sure deleting frame by |
I'd agree with @bsekachev. It would be much better with |
I'd really like this feature, happy with Alt+Del or X |
Agreed. Alt+Del is a good suggestion. |
@scottykwok , please let us know if you want to improve the PR? |
/check |
✔️ All checks completed successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for the contribution!
This fixes cvat-ai#5369 by adding keyboard shortcut [x] that delete a frame without prompt. Co-authored-by: Scotty Kwok <scottykwok@sebit.word> Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com>
Motivation and context
This fixes #5369 by adding keyboard shortcut [x] that delete a frame without prompt.
![image](https://user-images.githubusercontent.com/7172179/204511159-ab008b63-5033-4447-b18e-e07c3336d731.png)
How has this been tested?
Rebuild cvat/ui docker image locally and tested locally.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.