Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut to delete frame (fixes #5369) #5370

Merged

Conversation

scottykwok
Copy link
Contributor

@scottykwok scottykwok commented Nov 29, 2022

Motivation and context

This fixes #5369 by adding keyboard shortcut [x] that delete a frame without prompt.
image

How has this been tested?

Rebuild cvat/ui docker image locally and tested locally.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@nmanovic
Copy link
Contributor

@scottykwok , thanks for the contribution! Let's see if all tests are passed. Could you please add a function test for the feature? Thus we will be sure that it works after our modifications.

@klakhov , could you please review the PR?

@nmanovic nmanovic requested review from klakhov and removed request for bsekachev and nmanovic November 29, 2022 17:44
@bsekachev
Copy link
Member

I am not sure deleting frame by X is a good idea. Too many functional keys near the X. It might be often pressed accidentaly.
Also, I believe, deleting a frame should work with the same key Del as deleting in object (maybe with a modificator, etc. Need to think more about it.)

@klakhov
Copy link
Contributor

klakhov commented Nov 30, 2022

I'd agree with @bsekachev. It would be much better with Alt+Del.

@GeorgePearse
Copy link

I'd really like this feature, happy with Alt+Del or X

@scottykwok
Copy link
Contributor Author

Agreed. Alt+Del is a good suggestion.
Then I will try update the pull request accordingly.

@nmanovic nmanovic requested review from bsekachev and removed request for klakhov December 8, 2022 08:50
@nmanovic nmanovic changed the title Keyboard shortcut to delete frame (fixes #5369) [WIP] Keyboard shortcut to delete frame (fixes #5369) Dec 8, 2022
@nmanovic
Copy link
Contributor

nmanovic commented Dec 8, 2022

@scottykwok , please let us know if you want to improve the PR?

@bsekachev bsekachev changed the title [WIP] Keyboard shortcut to delete frame (fixes #5369) Keyboard shortcut to delete frame (fixes #5369) Dec 16, 2022
@bsekachev
Copy link
Member

/check

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

✔️ All checks completed successfully
📄 See logs here

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the contribution!

@nmanovic nmanovic merged commit 4fdac63 into cvat-ai:develop Dec 16, 2022
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
This fixes cvat-ai#5369 by adding keyboard shortcut [x] that delete a frame
without prompt.

Co-authored-by: Scotty Kwok <scottykwok@sebit.word>
Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcut to delete frame
5 participants