Fixed: cancel button is not visible when removing a label/attribute #8196
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe update enhances modal confirmation dialogs for the label editor in CVAT's UI. It refines the deletion confirmation messages and visual elements, improving the clarity and user experience. The changes include adding new icon imports, adjusting modal properties, and updating the text content to better inform users about irreversible actions. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- cvat-ui/src/components/labels-editor/label-form.tsx (2 hunks)
- cvat-ui/src/components/labels-editor/labels-editor.tsx (2 hunks)
Additional comments not posted (5)
cvat-ui/src/components/labels-editor/labels-editor.tsx (3)
10-10: Import change looks good.The import change from
ModalConfirmtomodalis appropriate given the updates in the modal confirmation handling.
11-11: Icon imports look good.The new icons imported from
@ant-design/iconsare appropriate for use in the modal confirmation dialog.
161-170: Modal confirmation dialog updates look good.The updates to the modal properties and content in the
handleDeletefunction improve clarity and user experience.cvat-ui/src/components/labels-editor/label-form.tsx (2)
8-8: Icon import looks good.The addition of the
ExclamationCircleOutlinedicon from@ant-design/iconsis appropriate for use in the modal confirmation dialog.
424-431: Modal confirmation dialog updates look good.The updates to the modal properties and content in the
renderDeleteAttributeButtonfunction improve clarity and user experience.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8196 +/- ##
===========================================
+ Coverage 83.37% 83.38% +0.01%
===========================================
Files 388 388
Lines 41300 41305 +5
Branches 3854 3854
===========================================
+ Hits 34432 34441 +9
+ Misses 6868 6864 -4
|
Motivation and context
Before:
After:
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Improvements