-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep EXIF rotation during YOLO importing #27
Conversation
@zhiltsov-max Please review this PR. The main changes are in |
@@ -156,14 +162,23 @@ def name_from_path(cls, path: str) -> str: | |||
|
|||
return osp.splitext(path)[0] | |||
|
|||
@classmethod | |||
def _image_loader(cls, *args, **kwargs): | |||
return load_image(*args, **kwargs, keep_exif=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that this change is local for yolo, but at the same time other formats are probably suffering from this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would suggest merging this hotfix first, and then implement a more universal solution
@zhiltsov-max I've added test |
Summary
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.