Skip to content

Commit

Permalink
Fail for SWIG 3.0.8 (#2656)
Browse files Browse the repository at this point in the history
Ran into this bug when compiling with python3 bindings: swig/swig#588

Instantiating any object crashes python. Since swig3.0.8 is currently the apt-get install for Ubuntu 16.04, I thought it'd be good to have a check for that. If python3 is preferred and the swig version is 3.0.8, it errors out and asks users to downgrade or upgrade SWIG.
  • Loading branch information
makaimann authored and 4tXJ7f committed Oct 22, 2018
1 parent 93f4888 commit 2f97221
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/bindings/CMakeLists.txt
Expand Up @@ -3,6 +3,13 @@ if(NOT ENABLE_SHARED)
endif()

find_package(SWIG 3.0.0 REQUIRED)

if(USE_PYTHON3 AND (SWIG_VERSION VERSION_EQUAL 3.0.8))
message(FATAL_ERROR
"\nSWIG ${SWIG_VERSION} is not supported for python3 bindings because of the following bug: https://github.com/swig/swig/issues/588
Please downgrade to 3.0.0-3.0.7 or upgrade.")
endif()

include(${SWIG_USE_FILE})

set(CVC4_SWIG_INTERFACE ${PROJECT_SOURCE_DIR}/src/cvc4.i)
Expand Down

0 comments on commit 2f97221

Please sign in to comment.