Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python package license #10327

Closed
dddejan opened this issue Jan 31, 2024 · 1 comment · Fixed by #10348
Closed

Python package license #10327

dddejan opened this issue Jan 31, 2024 · 1 comment · Fixed by #10348
Assignees
@daniel-larraz

Comments

@dddejan
Copy link
Contributor

dddejan commented Jan 31, 2024

I was looking at the python package licensing. It states BSD-3-Clause.

When I look at the libraries packaged I get

ls -l .venv/lib/python3.11/site-packages/cvc5/.dylibs/
total 57784
-rwxr-xr-x  1 dejajov  staff  27674448 Jan 31 13:19 libcvc5.1.dylib
-rwxr-xr-x  1 dejajov  staff    811952 Jan 31 13:19 libcvc5parser.1.dylib
-rw-r--r--  1 dejajov  staff    486384 Jan 31 13:19 libgmp.10.dylib
-rwxr-xr-x  1 dejajov  staff    321040 Jan 31 13:19 libpoly.0.1.13.dylib
-rwxr-xr-x  1 dejajov  staff    280480 Jan 31 13:19 libpolyxx.0.1.13.dylib

In particular LibPoly is licensed as LGPL3 and distributed with the package. Not an expert but this doesn't feel right.

If a downstream package picks up CVC5 it will assume it is BSD3 and not know that it also includes LGPL libraries. Just wanted to point this out to double check what is the correct thing to do.
@daniel-larraz daniel-larraz mentioned this issue Feb 5, 2024
Merged
@daniel-larraz daniel-larraz self-assigned this Feb 5, 2024
@daniel-larraz
Copy link
Contributor

daniel-larraz commented Feb 5, 2024 •
edited
Loading

@dddejan. Thank you for reporting this issue. I created a PR (#10348) that updates the license of the Python packages to reflect that the packages include artifacts under different licenses.

aniemetz pushed a commit that referenced this issue Feb 5, 2024
@daniel-larraz
Fix Python package licensing (#10348)
624dc1a 
This PR updates the `License` field of the Python wheel metadata to
reflect that the package includes artifacts under three different
licenses: BSD-3-Clause, LGPL-3.0-or-later, and MIT. It also includes a
COPYING file and associated license files in the `dist-info` directory
of the Python wheel.

It fixes #10327. It depends on #10339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-larraz daniel-larraz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Python package licensing daniel-larraz/cvc5
2 participants
@dddejan @daniel-larraz