Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure disequality splits are processed as lemmas #4380

Merged
merged 2 commits into from Apr 22, 2020

Conversation

ajreynol
Copy link
Member

Fixes #4379. This was caused by a splitting lemma rewriting to a conjunction, being processed as a fact, and having a pending phase requirement sent out assuming the inference was to be processed as a lemma. This forces 2 of the splits in the core solver to be always processed as lemmas.

@ajreynol ajreynol added major Priority simple Complexity labels Apr 22, 2020
@ajreynol ajreynol added this to the SMT-COMP 2020 milestone Apr 22, 2020
@ajreynol ajreynol requested a review from 4tXJ7f April 22, 2020 18:22
Copy link
Member

@4tXJ7f 4tXJ7f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4tXJ7f 4tXJ7f merged commit d64143f into cvc5:master Apr 22, 2020
@ajreynol ajreynol deleted the strSplitLemma branch April 22, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Priority simple Complexity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal failure on String formula at prop/cnf_stream.cpp:282
2 participants