Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye CVC4, hello cvc5! #6371

Merged
merged 12 commits into from Apr 21, 2021
Merged

Goodbye CVC4, hello cvc5! #6371

merged 12 commits into from Apr 21, 2021

Conversation

mpreiner
Copy link
Member

@mpreiner mpreiner commented Apr 15, 2021 •
edited

This commits changes the build system to cvc5 and removes the remaining
occurences of CVC4.
It further cleans up outdated/unused scripts in contrib/.

@mpreiner
Goodbye CVC4, hello cvc5!
313de58 
This commits changes the build system to cvc5 and removes the remaining
occurences of CVC4.
It further cleans up outdated/unused script in contrib/.
@mpreiner mpreiner added normal Priority moderate Complexity do not merge Do not merge this PR if you are not the author labels Apr 15, 2021
nafur
nafur reviewed Apr 16, 2021
View reviewed changes
Copy link
Member

@nafur nafur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/api/cpp/cvc5_kind.h Outdated Show resolved Hide resolved
src/base/check.h Outdated Show resolved Hide resolved
src/base/output.cpp Outdated Show resolved Hide resolved
src/main/signal_handlers.cpp Outdated Show resolved Hide resolved
nafur
nafur approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@nafur nafur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mpreiner mpreiner mentioned this pull request Apr 21, 2021
Merged
@mpreiner mpreiner removed the do not merge Do not merge this PR if you are not the author label Apr 21, 2021
@mpreiner mpreiner merged commit ae5ee4b into cvc5:master Apr 21, 2021
@mpreiner mpreiner deleted the cmake-switch-to-cvc5 branch April 21, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nafur nafur nafur approved these changes

@4tXJ7f 4tXJ7f Awaiting requested review from 4tXJ7f

@HanielB HanielB Awaiting requested review from HanielB

@barrettcw barrettcw Awaiting requested review from barrettcw

@ajreynol ajreynol Awaiting requested review from ajreynol

@aniemetz aniemetz Awaiting requested review from aniemetz

Assignees

@nafur nafur

@4tXJ7f 4tXJ7f

@HanielB HanielB

@barrettcw barrettcw

@ajreynol ajreynol

@aniemetz aniemetz

Labels
moderate Complexity normal Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mpreiner @nafur @4tXJ7f @HanielB @barrettcw @ajreynol @aniemetz