ff: kinds file and deps (enumerator, type-checker, rewriter) #9059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(somehow the generated file is still on my machine?)
ajreynol
requested changes
Aug 23, 2022
| @@ -311,6 +311,11 @@ std::string LogicInfo::getLogicString() const { | |||
| ss << "BV"; | |||
| ++seen; | |||
| } | |||
| if (d_theories[THEORY_FF]) | |||
There was a problem hiding this comment.
I'd just remove this (this is the reason why the PR is failing CI). For now, I would suggest enabling finite fields only when the logic is set to ALL.
Logic strings are in need of refactoring (at the SMT-LIB standard level), so this code will likely be rewritten later.
There was a problem hiding this comment.
Hmm. So most of my CLI regression tests (yet un-merged) use the QF_FF logic string, so I left this code and just fixed the failing test.
| @@ -445,6 +450,11 @@ void LogicInfo::setLogicString(std::string logicString) | |||
| enableTheory(THEORY_BV); | |||
| p += 2; | |||
| } | |||
| if (!strncmp(p, "FF", 2)) | |||
4tXJ7f
requested changes
Aug 25, 2022
Co-authored-by: Andres Noetzli <andres.noetzli@gmail.com>
|
Thanks for the review, Andres. I've address the specific comments, and re-named |
4tXJ7f
approved these changes
Sep 1, 2022
ajreynol
approved these changes
Sep 1, 2022
4tXJ7f
added a commit
to 4tXJ7f/cvc5
that referenced
this pull request
Sep 1, 2022
Previously, we had no configuration that tested the `--cocoa` option. This lead to broken unit tests when the option was enabled. PR cvc5#9059 fixed one of the unit tests. This commit adds `--cocoa` to a configuration to ensure that this does not happen in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ff kinds file and immediate dependencies.
The diff is huge, and I'd like to shrink it before proper review. Suggestions? I describe the contents of this PR below, as a dependency tree:
I guess I could stub out chunks of the type rules and theory rewriter? I guess I could also omit some parts of the kinds file, but I don't really know what parts depend on what, or if you are allowed to omit parts.