ff: groebner bases for incremental ideals #9199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajreynol
requested changes
Oct 5, 2022
|
|
||
| std::unique_ptr<context::Context> d_context; | ||
|
|
||
| CoCoA::ring d_polyRing; |
There was a problem hiding this comment.
Can you give some quick doc on these members?
What context do they depend on? When are they computed? Etc.
| void pop(); | ||
|
|
||
| private: | ||
| void ensureSolution(); |
| private: | ||
| void ensureSolution(); | ||
|
|
||
| std::unique_ptr<context::Context> d_context; |
There was a problem hiding this comment.
Good question. Documented.
ajreynol
reviewed
Oct 6, 2022
| EXPECT_EQ(ideal.hasSolution(), false); | ||
| } | ||
|
|
||
| #endif // CVC5_USE_COCOA |
There was a problem hiding this comment.
This has the same issue with the guard :)
|
Thanks for the comment, Andy. Indeed the documentation was not up to scruff. Let me know what you think now, and whether you have more comments. |
ajreynol
requested changes
Oct 7, 2022
| #include <CoCoA/SparsePolyRing.H> | ||
| #include <CoCoA/ring.H> | ||
| #include <CoCoA/symbol.H> | ||
| #endif // CVC5_USE_COCOA |
There was a problem hiding this comment.
Like the other unit tests, let's just guard the whole file.
ajreynol
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.