Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch mode results worse than non-batch #27

Open
endeleze opened this issue Jul 12, 2023 · 3 comments
Open

Batch mode results worse than non-batch #27

endeleze opened this issue Jul 12, 2023 · 3 comments

Comments

@endeleze
Copy link

Hi,

I tested the speed and match results using batch mode and non-batch mode respectively and found: although batch mode is faster, its accuracy is worse than non-batch mode. I have checked the matched points' coordinates on each image between batch or non-batch modes and found most of them are the same, but some are different.

I used a query image with 50 similar images to do testing and print the matched pairs number of two modes and get:

batch matched points num: 179
non-batch matched points num: 179
batch matched points num: 109
non-batch matched points num: 107
batch matched points num: 107
non-batch matched points num: 106
batch matched points num: 124
non-batch matched points num: 117
batch matched points num: 111
non-batch matched points num: 113
batch matched points num: 138
non-batch matched points num: 140
batch matched points num: 125
non-batch matched points num: 125
batch matched points num: 136
non-batch matched points num: 129
batch matched points num: 110
non-batch matched points num: 108
batch matched points num: 126
non-batch matched points num: 127
batch matched points num: 141
non-batch matched points num: 135
batch matched points num: 137
non-batch matched points num: 130
batch matched points num: 157
non-batch matched points num: 157
batch matched points num: 129
non-batch matched points num: 126
batch matched points num: 93
non-batch matched points num: 93
batch matched points num: 115
non-batch matched points num: 113
batch matched points num: 71
non-batch matched points num: 106
batch matched points num: 53
non-batch matched points num: 128
batch matched points num: 70
non-batch matched points num: 132
batch matched points num: 57
non-batch matched points num: 76
batch matched points num: 87
non-batch matched points num: 106
batch matched points num: 68
non-batch matched points num: 119
batch matched points num: 85
non-batch matched points num: 76
batch matched points num: 58
non-batch matched points num: 96
batch matched points num: 87
non-batch matched points num: 75
batch matched points num: 121
non-batch matched points num: 150
batch matched points num: 73
non-batch matched points num: 85
batch matched points num: 89
non-batch matched points num: 128
batch matched points num: 79
non-batch matched points num: 133
batch matched points num: 125
non-batch matched points num: 112
batch matched points num: 67
non-batch matched points num: 118
batch matched points num: 75
non-batch matched points num: 114
batch matched points num: 67
non-batch matched points num: 45
batch matched points num: 83
non-batch matched points num: 97
batch matched points num: 98
non-batch matched points num: 168
batch matched points num: 62
non-batch matched points num: 85
batch matched points num: 94
non-batch matched points num: 101
batch matched points num: 106
non-batch matched points num: 82
batch matched points num: 88
non-batch matched points num: 80
batch matched points num: 32
non-batch matched points num: 42
batch matched points num: 95
non-batch matched points num: 113
batch matched points num: 98
non-batch matched points num: 180
batch matched points num: 88
non-batch matched points num: 101
batch matched points num: 51
non-batch matched points num: 109
batch matched points num: 77
non-batch matched points num: 114
batch matched points num: 85
non-batch matched points num: 99
batch matched points num: 64
non-batch matched points num: 62

I also checked these matched pairs and found non-batch mode is more accurate, do you know why this happened? All other parameters remain the same in the two testings.

Thank you!

@Phil26AT
Copy link
Collaborator

Hi @endeleze

Thanks for reporting your insights. It is very hard to tell what the issue is, in theory batched inference should be identical without adaptive depth/width.

Any chance you can share your experiment (code+data, either share it here or send me a mail)? I am curious and would like to investigate this.

@ducha-aiki
Copy link
Contributor

I guess that batched stops for the depth levels for the whole batch, which sometimes is suboptiomal.

@kkamalrajk
Copy link

@endeleze , Could you please help me by sharing the code to batch process image pairs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants