Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 31 million developers.
Sign up
Pinned repositories
570 contributions in the last year
Contribution activity
February 2019
Created a pull request in ampproject/amphtml that received 9 comments
Skip flaky inabox tests
Example flaky test run: https://travis-ci.org/ampproject/amphtml/jobs/488921966
+42
−37
•
9
comments
- ✅Add visual test for amp-sidebar.
- ✅First few visual diff tests for amp-date-picker
- 🖍 Edit sidebar animations/design
- 🐛Change references from 'Pin It' to 'Save' in amp-pinterest.
- 🐛Re-implemented "Fixed NonXHR GET on amp-form with Async Input Elements"
- 🐛Modify amp-pinterest.css from displaying "Pin It" to "Save" as a button
- ✨ Implement arrows for carousel v2.
- ✅Fix carousel e2e tests.
- 🖍Clean up amp-pinterest button styling
- 🐛 Prevent toggle() from throwing error when no elements are selected.
- ✨ Add page sharing options for branching
- 🐛 Fix selectUp off-by-one bug in amp-selector.
Created an issue in ampproject/amphtml that received 6 comments
cannot mark class constructor as private
Bug in amphtml-internal/enforce-private-props prevents you from annotating a constructor as @private. It wants a trailing underscore, but you canno…
6
comments
- Support customary currency mask
- Undo is broken in amp-inputmask
- Multimask does not reset when all text is deleted
- Allow typing any separator-type character to trigger a mask to enter its separator
- Mask-entered characters are deleted when the user deletes a user-entered character
- amp-date-picker triggers incorrect change event with minimum-nights="0"
- FR: Support amp-form textarea autoexpand for elements that overflow initially
- Demo viewer.html does not put documents in visible state after sending visible message