Issues/8/create web application service #32
Conversation
leckijakub
requested review from
Debskij,
marekhering and
MateuszKepczynski
There was a problem hiding this comment.
Hi @leckijakub, @MateuszKepczynski!
Thanks for your awesome contribution! Despite my comments, I would suggest creating a new issue to easily keep track of the most important changes that are currently marked as comments with the TODO tag.
| POSTGRES_PASSWORD=splinter | ||
| POSTGRES_DB=splinter_db | ||
| POSTGRES_USER=postgres | ||
| POSTGRES_PASSWORD=1234 |
There was a problem hiding this comment.
Is there a way to store passwords in a more secure manner?
There was a problem hiding this comment.
@Debskij of course there are some ways but the question is if we want to introduce it now.
The simplest improvement would be to leave these variables empty and leave filling them to the person which would do the deployment. But that also means that each developer will have to do the same thing when they try to start the system from a freshly cloned repo.
I would suggest leaving credentials in configuration files until we plan the first release of the software.
There was a problem hiding this comment.
Great point, I feel that we should somehow keep the track of all the "shortcuts" that we currently use in order to simplify first local deployments. Maybe we can create a separate issue (or issues) for that case?
| @@ -0,0 +1,33 @@ | |||
| HELP.md | |||
| target/ | |||
| !.mvn/wrapper/maven-wrapper.jar | |||
There was a problem hiding this comment.
I am not an expert in java, therefor it's just a question, should we include maven-wrapper.jar in git?
Found on stack and default gitignore by toptal for maven that it is usually placed in .gitignore.
There was a problem hiding this comment.
Question to @MateuszKepczynski
There was a problem hiding this comment.
Its a stuff genereted from java code, tehres no need to keep this on github
webapp/backend/src/main/java/pl/splinter/backend/config/MyDataRestConfig.java
Outdated
Show resolved
Hide resolved
|
|
||
| spring.datasource.url=jdbc:postgresql://splinter_db:5432/splinter | ||
| spring.datasource.username=postgres | ||
| spring.datasource.password=1234 |
There was a problem hiding this comment.
Same as before, is there any more secure way to store those passwords?
There was a problem hiding this comment.
same as in #32 (comment)
| VALUES ('MBI-2022', 'Metody badawcze w informatyce', 'pan.doktor@pg.edu.pl'), | ||
| ('SOWW-2022', 'Systemy o wysokiej wydajności', 'pan.doktor@pg.edu.pl'), | ||
| ('BS-2022', 'Bezpieczeństwo systemów', 'pan.doktor@pg.edu.pl'), | ||
| ('BO-2022', 'Badania operacyjne', 'pan.doktor@pg.edu.pl'), | ||
| ('BS-2022', 'Biblioteki cyfrowe', 'pan.doktor@pg.edu.pl'), | ||
| ('UO-2022', 'Użyteczność oprogramowania', 'pan.doktor@pg.edu.pl'); |
There was a problem hiding this comment.
Was it tested against multiple users? Can we already have subjects owned by two different users?
There was a problem hiding this comment.
Question to @MateuszKepczynski
…ication. JDK version used: openjdk_11 Maven version used: 3.6.3
…tend application. In order to run the application in docker container, address 0.0.0.0 must be used to force PHP to listen to all available interfaces instead of only internal `localhost` interface.
…ker-compose configuration.
…stname. After dockerizing database is not running on the same container as backend and thus its address needs to be adjusted. Additionally remove unfinished tests as it was preventing application from building correctly.
leckijakub
force-pushed
the
issues/8/create_web_application_service
branch
from
7036ad2
to
0a15691
Compare
Hi @Debskij thanks! |
This combines following PRs:
Fulfills: #7 #8