Replace activesupport with corefines #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Grrr, you should really fix the tests on CI… It passes both on my machine and Travis (see here). |
|
Rejoice, for I have removed the wicked Semaphore CI's hook! It will bother us no more! |
|
👏 👍 |
|
And what about merging this little PR of mine? 🐱 |
|
Can you update corefines version and rebase? |
|
It’s IMHO not needed to update corefines, we are not using any newer refinements here. |
|
I have no idea why this is failing but I'd suspect an auth server. |
jnv
added a commit
that referenced
this pull request
Jul 8, 2015
Replace activesupport with corefines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refinements FTW! 😸