-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix date require #18
fix date require #18
Conversation
Do the tests fail due to missing permissions to secrets in Travis? |
Oh, I know, perhaps beacuse it is a separate fork. Blame integration specs... |
Also I have disabled coveralls notifications, hopefully it won't annoy us again. |
@jnv Looks like it's Travis feature:
I've tried configuring secrets in repo properties without any success. For my own fork it works just fine. |
Great, I'd like @jirutka to take a look at this. By the way, I think we could add VCR for integration specs so secrets are not needed for testing. |
Well, it looks like Travis issue:
This basically means that without cached VCR data builds should be disabled for external PRs. |
Not sure why it doesn't fail on travis, but on local I can't run the tests without the
require
statement.