Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix date require #18

Merged
merged 1 commit into from
Dec 2, 2017
Merged

fix date require #18

merged 1 commit into from
Dec 2, 2017

Conversation

deric
Copy link
Member

@deric deric commented Oct 16, 2017

Not sure why it doesn't fail on travis, but on local I can't run the tests without the require statement.

@jnv
Copy link
Contributor

jnv commented Oct 17, 2017

Do the tests fail due to missing permissions to secrets in Travis?
@deric I have added you to the Sirius team, let's see if it helps.

@jnv jnv requested a review from jirutka October 17, 2017 08:22
@jnv
Copy link
Contributor

jnv commented Oct 17, 2017

Oh, I know, perhaps beacuse it is a separate fork. Blame integration specs...

@jnv
Copy link
Contributor

jnv commented Oct 17, 2017

Also I have disabled coveralls notifications, hopefully it won't annoy us again.

@cvut cvut deleted a comment from coveralls Oct 17, 2017
@cvut cvut deleted a comment from coveralls Oct 17, 2017
@cvut cvut deleted a comment from coveralls Oct 17, 2017
@cvut cvut deleted a comment from coveralls Oct 17, 2017
@deric
Copy link
Member Author

deric commented Oct 17, 2017

@jnv Looks like it's Travis feature:

Encryption and decryption keys are tied to the repository. If you fork a project and add it to Travis CI, it will not access to the encrypted variables.

I've tried configuring secrets in repo properties without any success. For my own fork it works just fine.

@jnv
Copy link
Contributor

jnv commented Oct 17, 2017

Great, I'd like @jirutka to take a look at this. By the way, I think we could add VCR for integration specs so secrets are not needed for testing.

@coveralls
Copy link

coveralls commented Oct 17, 2017

Coverage Status

Coverage decreased (-1.04%) to 98.685% when pulling aa32cdb on deric:date into 5404000 on cvut:master.

@deric
Copy link
Member Author

deric commented Oct 17, 2017

Well, it looks like Travis issue:

Travis CI makes encrypted variables and data available only to pull requests coming from the same repository. These are considered trustworthy, as only members with write access to the repository can send them.

This basically means that without cached VCR data builds should be disabled for external PRs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.04%) to 98.685% when pulling 06ad445 on deric:date into 5404000 on cvut:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.04%) to 98.685% when pulling 06ad445 on deric:date into 5404000 on cvut:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.04%) to 98.685% when pulling 06ad445 on deric:date into 5404000 on cvut:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants