Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent type for convert_num() #105

Closed
svillemot opened this issue Aug 21, 2017 · 1 comment · Fixed by #107
Closed

Inconsistent type for convert_num() #105

svillemot opened this issue Aug 21, 2017 · 1 comment · Fixed by #107

Comments

@svillemot
Copy link

This is Debian bug #744955:

The last argument of function convert_num() is declared in src/C/base.c to be an int.
But in src/C/dense.c and src/C/sparse.c, the very same argument is declared to be an int_t.

This can create undefined behavior or crashes on platforms where int and Py_ssize_t have different bit width.

Cheers,
@martinandersen
Copy link
Contributor

Thanks for pointing this out, we'll look into it.

martinandersen added a commit that referenced this issue Sep 6, 2017
@martinandersen
Compatibility update
f5f35d8 
- setup.py: removes calls to deprecated platform.dist()
- base.c: fixes #105
- blas.c: fixes confusing indentation
- cholmod.c: fixes docstring typo and unused variable warning
- sparse.c: fixes unused variable warning
@martinandersen martinandersen mentioned this issue Sep 7, 2017
Merged
martinandersen added a commit that referenced this issue Sep 7, 2017
@martinandersen
Compatibility update
009817d 
- setup.py: removes calls to deprecated platform.dist()
- base.c: fixes #105
- blas.c: fixes confusing indentation
- cholmod.c: fixes docstring typo and unused variable warning
- sparse.c: fixes unused variable warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compatibility updates cvxopt/cvxopt
2 participants
@svillemot @martinandersen