Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend is_nonneg() of diag_mat to check if arg is psd [issue 1213] #1242

Merged
merged 1 commit into from Feb 17, 2021

Conversation

phschiele
Copy link
Collaborator

This PR adds @SteveDiamond 's proposed improvement for the is_nonneg() check in the diag_mat class, as per discussion in #1213. Also, the tests are extended to cover this case.

Contributing guideline checks:

  • no regression change
  • no relevant change in benchmark timings (25.33s pre-change vs. 25.05s after the change)
  • flake8 passing

@SteveDiamond
Copy link
Collaborator

LGTM! Thanks for fixing this!

@SteveDiamond SteveDiamond merged commit f2a94d6 into cvxpy:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants