more fixes for geo_mean canonicalization #1685 (follow-up on PR #1687) #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rileyjmurray
added a commit
to rileyjmurray/cvxpy
that referenced
this pull request
Mar 8, 2022
rileyjmurray
added a commit
that referenced
this pull request
Mar 8, 2022
* all semantic versioning infrastructure accumulated on master (PRs #1598, #1617, #1624). Bugfixes for kron with parameters (issue #1656), M1 build failures (issue #1604), Anderson Acceleration docs and warning for SCS 2.X (follow-up from PR #1670). * Propagate bugfix in PR #1607 * Propagate bugfixes from PR #1660 * Propagate bugfix in PR #1628 * Propagate bugfixes from PR #1621 * Propogate commit to fix #1581 * Propagate regression fix from PR #1677 * update test for cumsum, new test for cummax, fix cummax * Propagate NumPy error handling from PR #1648 * Propagate bugfix from PR #1648 (but move location of tests) * propagate bugfix from PR #1687 * Propagate bugfixes in PR #1688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My change to
dyad_completionin PR #1687 wasn't enough to solve all thegeo_meanbugs now reported #1685. A full fix required makingdyad_completionrecursive. Previous test cases never hit this new recursive code path. I added a new file for unit tests relating tocvxpy.utilities.power_tools.py.Note: only one of the new tests hits the new code path. The other test is there to help us address #1223.
Type of change
Contribution checklist