Fix sign error with log_sum_exp #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
rileyjmurray
added
backport bugfix to 1.1 and 1.2
needs discussion
|
I've propagated this change to 1.1.20. Will make a PR shortly. |
rileyjmurray
removed
backport bugfix to 1.1 and 1.2
needs discussion
rileyjmurray
pushed a commit
that referenced
this pull request
May 16, 2022
* fix sign error with log_sum_exp * docs (cherry picked from commit 06854d9)
|
Propagated to 1.2.1. |
rileyjmurray
pushed a commit
that referenced
this pull request
May 16, 2022
* fix sign error with log_sum_exp * docs (cherry picked from commit 06854d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Stephen Boyd noticed that log_sum_exp of a non-negative value has unknown sign, where it should be non-negative. This PR fixes the sign error.
Type of change
Contribution checklist