More web doc updates #1732
Merged
More web doc updates #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveDiamond
reviewed
Apr 3, 2022
SteveDiamond
reviewed
Apr 3, 2022
SteveDiamond
reviewed
Apr 3, 2022
| The output :math:`X'` of ``reshape(X, (m', n'))`` is the matrix :math:`X` cast into an :math:`m' \times n'` matrix. | ||
| The entries are taken from :math:`X` in column-major order and stored in :math:`X'` in column-major order. | ||
| Formally, :math:`X'_{ij} = \mathbf{vec}(X)_{m'j + i}`. | ||
| The output :math:`y = \mathbf{upper\_tri}(X)` is formed by concatenating partial rows of :math:`X`. |
There was a problem hiding this comment.
I think upper_tri can include or exclude the diagonal based on a flag.
There was a problem hiding this comment.
No, it's just the strict upper triangle. There's a helper function in upper_tri.py called vec_to_upper_tri which supports a flag, but there isn't an analogous function for going the other way.
There was a problem hiding this comment.
That would be a nice feature improvement
SteveDiamond
reviewed
Apr 3, 2022
|
@SteveDiamond have you looked over all the changes? If so then I'll commit the fixes directly to release/1.2.x. |
|
Yeah, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for the following functions was missing from https://www.cvxpy.org/tutorial/functions/index.html:
This PR adds that documentation. It also ...
kroncan accept Variables in either argument,