New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch SCS timings to seconds #1880
Conversation
Steven Diamond seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Benchmarks that have stayed the same:
|
Fixes #1878. Failures unrelated and known mosek tests. |
Confirming that SCS 2.x and 3.x are affected:
3.x:
Side note: Interesting to see that 2.x was much faster on this problem instance (I fixed eps=1e-4 in both cases). |
Co-authored-by: Steven Diamond <steven@gridmatic.com>
Co-authored-by: Steven Diamond <steven@gridmatic.com>
* fix osqp warm start (#1882) * switch SCS timings to seconds (#1880) Co-authored-by: Steven Diamond <steven@gridmatic.com> * merge fix * merge fix * Fix SOC residual (#1844) * fix SOC residual * dimension test * Suggestion for how to compute SOC residual (#1853) Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Fix bug with diff (#1835) * fix #1834 * test error Co-authored-by: Steven Diamond <steven@gridmatic.com> * fix #1828 (#1829) * fix mosek * switch pcp opt vals back * resolved merge conflicts * removed mi_lp_5 test * Update __init__.py Resolve #1910 * allow lists as shape definitions * fix types * fix types for 3.6 * fix gradient for multidimensional quad form (#1854) * fix multidimensional quad form * autoblack messed up line ordering * Adding edge case handling for string inputs into norm (#1871) * Adding edge case handling for string inputs into norm Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> * Update cvxpy/atoms/norm.py Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Adding norm exception tests to ensure that invalid string inputs are caught Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> Co-authored-by: Steven Diamond <steven@gridmatic.com> Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: Fabian Schramm <55981657+fabinsch@users.noreply.github.com> Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> Co-authored-by: Riley Murray <rileyjmurray@users.noreply.github.com> Co-authored-by: Robert Huisman <74955560+roberthuisman@users.noreply.github.com> Co-authored-by: KerimovEmil <emilkerimov93@gmail.com>
* fix osqp warm start (#1882) * switch SCS timings to seconds (#1880) Co-authored-by: Steven Diamond <steven@gridmatic.com> * merge fix * fix test * resolve merge * Fix SOC residual (#1844) * fix SOC residual * dimension test * Suggestion for how to compute SOC residual (#1853) Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Fix bug with diff (#1835) * fix #1834 * test error Co-authored-by: Steven Diamond <steven@gridmatic.com> * fix #1828 (#1829) * cap ortools at 9.3 * fix mosek * switch pcp opt vals back * resolve merge conflict * Update __init__.py Resolve #1910 * allow list as shape input * fix gradient for multidimensional quad form (#1854) * fix multidimensional quad form * autoblack messed up line ordering * Adding edge case handling for string inputs into norm (#1871) * Adding edge case handling for string inputs into norm Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> * Update cvxpy/atoms/norm.py Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Adding norm exception tests to ensure that invalid string inputs are caught Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> Co-authored-by: Steven Diamond <steven@gridmatic.com> * Fix time_limit_sec for GLOP and PDLP (#1859) Fixes #1858 Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: Fabian Schramm <55981657+fabinsch@users.noreply.github.com> Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> Co-authored-by: Riley Murray <rileyjmurray@users.noreply.github.com> Co-authored-by: Robert Huisman <74955560+roberthuisman@users.noreply.github.com> Co-authored-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: Miles Lubin <miles.lubin@gmail.com>
* fix osqp warm start (#1882) * switch SCS timings to seconds (#1880) Co-authored-by: Steven Diamond <steven@gridmatic.com> * merge fix * merge fix * Fix SOC residual (#1844) * fix SOC residual * dimension test * Suggestion for how to compute SOC residual (#1853) Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Fix bug with diff (#1835) * fix #1834 * test error Co-authored-by: Steven Diamond <steven@gridmatic.com> * fix #1828 (#1829) * fix mosek * switch pcp opt vals back * resolved merge conflicts * removed mi_lp_5 test * Update __init__.py Resolve #1910 * allow lists as shape definitions * fix types * fix types for 3.6 * fix gradient for multidimensional quad form (#1854) * fix multidimensional quad form * autoblack messed up line ordering * Adding edge case handling for string inputs into norm (#1871) * Adding edge case handling for string inputs into norm Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> * Update cvxpy/atoms/norm.py Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Adding norm exception tests to ensure that invalid string inputs are caught Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> Co-authored-by: Steven Diamond <steven@gridmatic.com> * disallow float for diamatrix values (#1931) * add setup.cfg * Make log_det robust to numerical issues with complex data (#1866) * log_det takes Hermitian part of its input, therefore can assume that "sign" from numpys slogdet is real. * Update test_complex.py * Update test_complex.py Make certain failing tests verbose, so we can see why logdet tests fail on a small number of platforms. * guess for fix * lower precision of test log det * Update cvxpy/tests/test_complex.py Remove verbose Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Update cvxpy/tests/test_complex.py Remove verbose from test Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> Co-authored-by: Steven Diamond <diamond.po.central@gmail.com> Co-authored-by: Steven Diamond <steven@gridmatic.com> Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> * Adapt to API changes in gurobipy (#1962) Signed-off-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: Fabian Schramm <55981657+fabinsch@users.noreply.github.com> Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com> Co-authored-by: Riley Murray <rileyjmurray@users.noreply.github.com> Co-authored-by: Robert Huisman <74955560+roberthuisman@users.noreply.github.com> Co-authored-by: KerimovEmil <emilkerimov93@gmail.com> Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com> Co-authored-by: Robert Luce <2168992+rluce@users.noreply.github.com>
Description
Switches SCS timings from milliseconds to seconds.
Issue link (if applicable): #1878
Type of change
Contribution checklist