Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct handling of KNOWN_SOLVER_ERRORS in test_constant_atoms.py #1984

Merged
merged 1 commit into from Dec 24, 2022
Merged

correct handling of KNOWN_SOLVER_ERRORS in test_constant_atoms.py #1984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 9 additions & 6 deletions cvxpy/tests/test_constant_atoms.py
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@
limitations under the License.
"""

import collections
import itertools
import math

Expand Down Expand Up @@ -56,10 +57,9 @@ def log_sum_exp_axis_0(x): return cp.log_sum_exp(x, axis=0, keepdims=True) # no
def log_sum_exp_axis_1(x): return cp.log_sum_exp(x, axis=1) # noqa E371


# Atom, solver pairs known to fail.
KNOWN_SOLVER_ERRORS = [
(cp.xexp, cp.MOSEK) # really, cp.xexp(cp.pos(expr)).
]
# map from solver name to a list of strings for atoms that fail.
KNOWN_SOLVER_ERRORS = collections.defaultdict(list)
KNOWN_SOLVER_ERRORS[cp.MOSEK] = ['xexp']

atoms_minimize = [
(cp.abs, (2, 2), [[[-5, 2], [-3, 1]]],
Expand Down Expand Up @@ -305,6 +305,10 @@ def log_sum_exp_axis_1(x): return cp.log_sum_exp(x, axis=1) # noqa E371
def check_solver(prob, solver_name) -> bool:
"""Can the solver solve the problem?
"""
atom_str = str(prob.objective.args[0])
SteveDiamond marked this conversation as resolved.
Show resolved Hide resolved
for bad_atom_name in KNOWN_SOLVER_ERRORS[solver_name]:
if bad_atom_name in atom_str:
return False
try:
if solver_name == ROBUST_CVXOPT:
solver_name = CVXOPT
Expand All @@ -326,8 +330,7 @@ def run_atom(atom, problem, obj_val, solver, verbose: bool = False) -> None:
print(problem.objective)
print(problem.constraints)
print("solver", solver)
if check_solver(problem, solver) and \
not (atom, solver) in KNOWN_SOLVER_ERRORS:
if check_solver(problem, solver):
tolerance = SOLVER_TO_TOL[solver]

try:
Expand Down