Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Composer version 2 #321

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Add support for Composer version 2 #321

merged 1 commit into from
Sep 10, 2020

Conversation

hussainweb
Copy link

Cherry picking from #309

"packages": [],
"packages-dev": [
{
"name": "composer/ca-bundle",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a lot of unrelated changes got caught in the cherry-pick.
I think you should revert the composer.lock file to 972fac4 then run composer update --lock.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about that. Is there a reason there is a composer.lock. It typically isn't in version control for libraries. It doesn't get used anyway when requiring a package.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these changes might be because I also changed the version constraint for composer/composer to "^1.0 || ^2.0". That has introduced new packages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I didn't see you changed the composer/composer dev requirement.
That would indeed explain it.

@mxr576
Copy link

mxr576 commented Jul 28, 2020

I am doing my own testing and bumping issues, like this one: composer/composer#9079

@cweagans cweagans merged commit bba9dab into cweagans:1.x Sep 10, 2020
@hussainweb hussainweb deleted the 1.x branch September 10, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants