Changed jteeuwen/go-bindata to mjibson/esc #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/mjibson/esc the reason for changing go-bindata to esc - is: `go-bindata creator deleted their @github account and someone else created a new account with the same name.` jteeuwen/go-bindata#5 https://twitter.com/francesc/status/961249107020001280 After research some of alternatives - `esc` - is looks like one of the best choice https://tech.townsourced.com/post/embedding-static-files-in-go/
|
Thanks for this! I wasn't aware that |
|
@mekegi: You'll need to resolve merge conflicts before merging. |
cweill
previously approved these changes
Jul 21, 2018
cweill
approved these changes
Jul 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for changing go-bindata to esc - is:
jteeuwen/go-bindata#5
After research some of alternatives -
esc- is looks like one of thebest choice
https://tech.townsourced.com/post/embedding-static-files-in-go/