Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delete_csr test and change flatvector to constant vector #63

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

vlowingkloude
Copy link
Collaborator

In this PR, I fixed the format of delete_csr.test. Also, I changed the return vector type of UDF delete_csr from Flat to constant. But the SIGSEGV issue is not solved yet. :(

@Dtenwolde
Copy link
Collaborator

I'll take a look why it seg faults! :)

@Dtenwolde
Copy link
Collaborator

The seg fault occurs because the query is being run multiple times when the pragma enable_verification is enabled. This pragma will run the query multiple times with different modes. It will rewrite the string using ToString, or serialize and deserialize and re-execute to verify it gets the same results. However, the CSR building is not handling it properly. I am not sure if we should overwrite the CSR or not, but I'll create an issue anyway and deal with this later. The test file now completes as expected :)

@Dtenwolde Dtenwolde merged commit ef820fb into dev Apr 13, 2023
@Dtenwolde Dtenwolde deleted the fixdelcsr_f2c branch April 13, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants