Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only start initialization the configuration once #17

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

peternied
Copy link

Description

Only start initialization the configuration once

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <peternied@hotmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (b3b6de7) 65.19% compared to head (66dcfce) 66.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           initialization-fix      #17      +/-   ##
======================================================
+ Coverage               65.19%   66.54%   +1.34%     
======================================================
  Files                     298      298              
  Lines                   21217    21211       -6     
  Branches                 3460     3458       -2     
======================================================
+ Hits                    13833    14115     +282     
+ Misses                   5667     5372     -295     
- Partials                 1717     1724       +7     
Files Coverage Δ
...g/opensearch/security/support/ConfigConstants.java 95.23% <ø> (ø)
...ecurity/configuration/ConfigurationRepository.java 73.03% <81.25%> (ø)

... and 36 files with indirect coverage changes

…eep security manager state

Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
@cwperks
Copy link
Owner

cwperks commented Jan 4, 2024

Thank you for opening this @peternied! I will incorporate these changes into the PR against the main repo.

@peternied peternied merged commit 4d53edc into cwperks:initialization-fix Jan 4, 2024
76 checks passed
@peternied peternied deleted the initialization-fix branch January 4, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants