Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Ability to select language of labels #84

Open
15 of 21 tasks
SusanBrown opened this issue May 12, 2017 · 15 comments
Open
15 of 21 tasks

Ability to select language of labels #84

SusanBrown opened this issue May 12, 2017 · 15 comments

Comments

@SusanBrown
Copy link
Contributor

SusanBrown commented May 12, 2017

I know we've flagged this previously but I can't find an issue for it. @smurp this is becoming more of a problem as more of our ontology is translated: it draws on French and English labels indiscriminately.

  • make a language path setting
  • make node labels respect language path
  • make class picker respect language path
  • make edge picker respect language path
  • support wildcard ANY, NOLANG and ALL keywords
  • provide error message and docs
  • make the setting less fragile when user submits a syntax error (handle update and change differently)
  • support labels (which are in human languages) rather than ids (which are not) on boxes in the pickers
  • add multiple language variants on the TreeCtrl (ie Taxon or Predicate) instances
  • support alteration of labels on the boxes in the pickers
  • support reordering (sorting) of the boxes in the pickers to reflect language change
  • reorder class_picker
  • reorder predicate_picker
  • support triggering of recoloring of the pickers when reordering happens
  • restore expander/collapser, currently lost when language changes
  • fix anything label disappearing on language change
  • update_labels_on_pickers before resort_recursively
  • recolor nodes after resorting classes
  • recolor edges after resorting predicates
  • ensure names are propagated to predicate picker
  • add setting for name propagation to predicate picker
@smurp
Copy link
Collaborator

smurp commented May 12, 2017 via email

@smurp
Copy link
Collaborator

smurp commented Jun 13, 2017

Added language path setting and made node labels respect it. Also deployed to alpha.

smurp/huviz@38e2f32

@smurp
Copy link
Collaborator

smurp commented Jun 14, 2017

deployed ANY, NOLANG, ALL, docs and error message to alpha

@SusanBrown
Copy link
Contributor Author

Working great! Love the popup explanation if one puts in something incorrect.

Can I just suggest glossing the examples?

image

fr:en means show French labels when available and then English
en:ANY:NOLANG means show English labels first, then any other labels
ALL shows all language labels at once; best used alone

[that is if I have it right for ALL -- see new issue]

@SusanBrown
Copy link
Contributor Author

Language ALL:

I am not sure exactly what it does because I don't see the French label for acrostic (acrostiche) when I use the ALL setting, even though it is showing up when I designed fr, and a search on "like acrostiche" does nothing

image

@smurp
Copy link
Collaborator

smurp commented Jun 15, 2017

It shows ALL the different "value"@lang pairs, comma delimited. If there is a NOLANG version it just tacks that on at the end, in quotes. I see things like:

"jewish"@en, "juif"@fr
"Context"@en, "Contexte"@fr
"dog"@en, "chien"@fr, "pooch"   <--- for example, where 'pooch' is NOLANG

Again, a NOLANG version is when there is no language specified for a label.

I am currently seeing

"acrostic"@en, "acrostiche"@fr

using "HuVizSHARP2017"/"CWRC Ontology sans Genres" and the command

Label ALL like 'acrostic' .

@smurp
Copy link
Collaborator

smurp commented Jun 15, 2017

The bug you are reporting DID exist but I think that version was only running on alpha for a couple of hours yesterday. Any dataset recommendation so I can reproduce this?

@ghost
Copy link

ghost commented Jun 15, 2017 via email

@smurp
Copy link
Collaborator

smurp commented Jun 16, 2017

Maybe I'm wrong about when the bug-fixed version was deployed?!? I would be surprised if that could be reproduced. :-)

@smurp
Copy link
Collaborator

smurp commented Jun 16, 2017

acrostic_all

Oh yeah, I remembered to include the watermark in the screenshot to document the code version.

How about if I up the priority of including dataset and ontology identifiers in the watermark.

@SusanBrown
Copy link
Contributor Author

SusanBrown commented Jun 16, 2017 via email

@cmiya
Copy link
Collaborator

cmiya commented Sep 8, 2017

I noticed that make class picker/edge picker respect language path are still unchecked in the task list in the initial issue description. How are the language settings working? Are there still bugs? Or can we close this issue?

@cmiya cmiya closed this as completed Sep 8, 2017
@cmiya cmiya reopened this Sep 8, 2017
@smurp
Copy link
Collaborator

smurp commented Jun 8, 2018

Getting the pickers to respect the language path has in fact not been done yet. These require the following changes to the TreePicker code:

  • support labels (which are in human languages) rather than ids (which are not) on boxes in the pickers
  • add multiple language variants on the TreeCtrl (ie Taxon or Predicate) instances
  • support alteration of labels on the boxes in the pickers
  • support reordering (sorting) of the boxes in the pickers to reflect language change
  • reorder class_picker
  • reorder predicate_picker
  • support triggering of recoloring of the pickers when reordering happens

.... and that is why it hasn't happened yet. :-)

PS these steps have been moved to the main issue description

@smurp
Copy link
Collaborator

smurp commented Sep 18, 2018

@smurp
Copy link
Collaborator

smurp commented Sep 24, 2018

fixed anything label disappearing on language change with
smurp/huviz@f833a03

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants