Temporal subject handling

[ilovan]

Taxonomy reference is required : see /admin/structure/taxonomy/manage/temporal_subjects/overview

Workbench check fails on that field

[ilovan]

https://cwrc.ca/islandora/object/reed%3Aaeb808b5-2c93-4e94-a1f4-52e7d3be016b/datastream/MODS/version/0/view
Temporal subject in this case is a date range expressed in MODS as

<subject>
<temporal point="start">1501</temporal>
</subject>
<subject>
<temporal point="end">1600</temporal>
</subject>

In the output of the transform to workbench format, it gets stored as 1501|1600 in the field_temporal_subject

[jefferya]

A second area of the temporal subject failing is if the subject is a year only (e.g., 1582) -- workbench interprets as a reference id instead of a label. Details of the problem: mjordan/islandora_workbench#337 (comment)

[jefferya]

The following commit helps incrementally in these cases

• only text
• only one begin/end point

Failing cases:

• mix of text and begin/end
• multiple begin/end pairs

islandora-etl/transform_to_workbench/islandora7_to_workbench_utils.xquery

Lines 529 to 549 in 9a8a9e9

	(: mods/subject/temporal :)
	(: needs to handle both a text plus a point="begin" and point="end" :)
	declare function th:get_subject_temporal($node as node()) as xs:string
	{
	let $list :=
	$node/resource_metadata/mods:mods/mods:subject/mods:temporal
	return
	if (exists($list[not(exists(@point))])) then (
	string-join($list/text(), $th:WORKBENCH_SEPARATOR)
	)
	else if ($list[@point] and not($list[not(exists(@point))])) then (
	(: todo: verify assumtion order of point="begin" and point="end" in docs :)
	string-join($list/text(), $th:EDTF_RANGE_SEPARATOR)
	)
	else if (not(exists($list))) then (
	""
	)
	else (
	fn:error(xs:QName('subject_temporal'), concat('subject temporal combination not handled - report bug: ', th:get_id($node)))
	)
	};

[jefferya]

@ilovan

A question if there is a temporal point start but no end

  <mods:subject>
    <mods:temporal point="start">2000</mods:temporal>
  </mods:subject>
  <mods:subject>
    <mods:temporal point="start">2001</mods:temporal>
  </mods:subject>

Is this the expected output

2000_workbench_separator_2001

Or should each have an open range like this 2000/

[jefferya]

Regarding the year (number only) aspect, my best idea (untested) to date:

1. extract terms from CSV
2. use create terms to add https://mjordan.github.io/islandora_workbench_docs/creating_taxonomy_terms/
3. in CSV, map problematic temporal subjects (e.g., 2000) to the ID generated in the previous step
4. ingest via Islandora Workbench