Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [0627] 同時押し関連の英訳を見直し #1378

Merged
merged 1 commit into from
Jan 7, 2023
Merged

chore: [0627] 同時押し関連の英訳を見直し #1378

merged 1 commit into from
Jan 7, 2023

Conversation

cwtickle
Copy link
Owner

@cwtickle cwtickle commented Jan 4, 2023 •
edited
Loading

🔨 変更内容 / Details of Changes

  1. 同時押し関連の英訳を見直しました。
    • 単押し：1push -> Single
    • 同時押し：2push -> Chord
    • 3つ押し以上：3push+ -> Triad+
    • 多重押し位置：3-Push positions -> Polychord positions
    • 同時補正：N-Push -> Chords

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. 直訳のままになっていたため、見直しました。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2023

Code Climate has analyzed commit 4239308 and detected 0 issues on this pull request.

View more on Code Climate.

@cwtickle cwtickle merged commit e50e1cd into develop Jan 7, 2023
@cwtickle cwtickle added the need-to-fix-supportVer. サポートバージョンへの修正が必要な場合にラベル付け label Jan 7, 2023
@cwtickle
Copy link
Owner Author

cwtickle commented Jan 7, 2023

不具合ではありませんが、表示の問題として過去バージョンにも例外的に対応します。

@cwtickle cwtickle mentioned this pull request Jan 7, 2023
Merged
@cwtickle cwtickle deleted the feature/0627-lang branch January 11, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
func:Settings need-to-fix-supportVer. サポートバージョンへの修正が必要な場合にラベル付け
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cwtickle