Add ccache to the build if available #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enables ccache in TravisCI
|
Seems that linux + clang build is failing, but might be a ccache + clang bug (http://petereisentraut.blogspot.com/2011/05/ccache-and-clang.html) |
|
Oh, nice find. I’ve just learnt to live with those warnings in Travis on my
own projects. I’ll submit a fix once I get a couple of spare minutes 😊
…On Sun, 22 Apr 2018 at 11:24, Cong ***@***.***> wrote:
Seems that linux + clang build is failing, but might be a ccache + clang
bug (http://petereisentraut.blogspot.com/2011/05/ccache-and-clang.html)
This could be fixed by having clang ignore unused arguments
-Qunused-arguments, setting envvar CCACHE_CPP2=yes (
http://petereisentraut.blogspot.com/2011/09/ccache-and-clang-part-2.html),
or using an updated ccache which fixes this bug (
https://bugzilla.samba.org/show_bug.cgi?id=8118 version 3.2). I can look
into this when I next get time and access to a linux environment, or do you
have time?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#553 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKAx178xEqQLw_sPj-hiX_Ko_mAhr5Eks5trExGgaJpZM4Tarw2>
.
|
LiquidityC
force-pushed
the
add_ccache_to_build
branch
from
7e16299
to
25e266f
Compare
|
Ok, didn't realize that there were multiple CMakeLists.txt files. I'll need to fiddle more than I thought. I'll try again later 😃 |
cxong
reviewed
Apr 22, 2018
CMakeLists.txt
Outdated
| link_directories(${SDL2_LIBRARY_DIRS} ${SDL2_IMAGE_LIBRARY_DIRS} ${SDL2_MIXER_LIBRARY_DIRS}) | ||
|
|
||
| if(CCACHE_FOUND) | ||
| set(ENV{CCACHE_CPP2} "yes") | ||
| if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ccache to the build to benefit those who have it installed. But it comes bundled in most Linux package managers and really speeds up successive compiles. There should be no impact if you don't have ccache installed.
Also enabled ccache in TravisCI.