Add authn-local support to the API #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
izgeri
reviewed
Dec 18, 2017
lib/conjur/base.rb
Outdated
| self.token_born = gettime | ||
| def gettime | ||
| monotonic_time | ||
| end |
There was a problem hiding this comment.
If the gettime method is the same in both APIKeyAuthenticator and LocalAuthenticator, why not include it in the TokenExpiration module like you did with update_token_born? Why even have a method for this - you could just replace calls to gettime with monotonic_time
|
@izgeri back in your court... |
izgeri
approved these changes
Dec 18, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authn-local service is now available in both v4 and v5.
This pull request adds
Conjur::API.authenticate_local, which uses authn-local according to theConjur.configuration.versionsetting.Build results : https://jenkins.conjur.net/job/cyberark--conjur-api-ruby/job/authn_local/