Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Conjur container build #2079

Merged
merged 1 commit into from Mar 24, 2021
Merged

Fix Conjur container build #2079

merged 1 commit into from Mar 24, 2021

Conversation

micahlee
Copy link
Contributor

What does this PR do?

This PR bumps the version of a sub-dependency mimemagic to version 0.3.6. The prior version, 0.3.5, was yanked from RubyGems and is not available to install.

What ticket does this PR close?

Resolves #1978

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

API Changes

  • The OpenAPI spec has been updated to meet new API changes (or an issue has been opened), or
  • The changes in this PR do not affect the Conjur API

@micahlee
Bump the gem version for mimemagic
7975364 
This is a sub-dependency of the activestorage gem and the `0.3.5` version
was yanked from rubygems, so we've updated this to `0.3.6`.
@micahlee micahlee marked this pull request as ready for review March 24, 2021 15:04
@micahlee micahlee requested a review from a team as a code owner March 24, 2021 15:04
h-artzi
h-artzi approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@h-artzi h-artzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codeclimate
Copy link

codeclimate bot commented Mar 24, 2021

Code Climate has analyzed commit 7975364 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.4% (0.0% change).

View more on Code Climate.

@h-artzi h-artzi merged commit d8234d4 into master Mar 24, 2021
@h-artzi h-artzi deleted the 1978-broken-build branch March 24, 2021 15:29
@micahlee micahlee mentioned this pull request Mar 25, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-artzi h-artzi h-artzi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Master Build Failure
2 participants
@micahlee @h-artzi