Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Conjur build #2084

Merged
merged 1 commit into from Mar 26, 2021
Merged

Fix Conjur build #2084

merged 1 commit into from Mar 26, 2021

Conversation

micahlee
Copy link
Contributor

@micahlee micahlee commented Mar 25, 2021

What does this PR do?

Connected to #2079 , mimemagic version 0.3.6 was also removed from RubyGems, so this PR bumps the version to 0.3.7 to fix the container build.

See for more information: mimemagicrb/mimemagic#98, rails/rails#41750

What ticket does this PR close?

N/A

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

API Changes

  • The OpenAPI spec has been updated to meet new API changes (or an issue has been opened), or
  • The changes in this PR do not affect the Conjur API

@micahlee micahlee requested a review from a team as a code owner March 25, 2021 17:06
@micahlee micahlee force-pushed the fix-mimemagic-version branch 2 times, most recently from b835360 to c2ce98a Compare March 25, 2021 19:29
This is a sub-dependency of the activestorage gem and the `0.3.6` version
was yanked from rubygems, so we've updated this to `0.3.7`.
@codeclimate
Copy link

codeclimate bot commented Mar 26, 2021

Code Climate has analyzed commit 6974c3e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.4% (0.0% change).

View more on Code Climate.

@jtuttle jtuttle merged commit 995aaf2 into master Mar 26, 2021
@jtuttle jtuttle deleted the fix-mimemagic-version branch March 26, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants